Skip to content

OPSEXP-3042: set ADF download vars as adf_app role's arguments #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alxgomz merged 31 commits into from
Feb 18, 2025
Merged

OPSEXP-3042: set ADF download vars as adf_app role's arguments #1061

alxgomz merged 31 commits into from
Feb 18, 2025

Conversation

@alxgomz
Copy link
Contributor

@alxgomz alxgomz commented Feb 11, 2025

@alxgomz alxgomz changed the title OPSEXP-3042: set ADF download vars as adf_ap role's arguments OPSEXP-3042: set ADF download vars as adf_app role's arguments Feb 12, 2025
@alxgomz alxgomz requested review from gionn and pmacius and removed request for gionn February 12, 2025 13:48
pmacius
pmacius reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove vars from 7.3 extra vars

gionn
gionn reviewed Feb 13, 2025
View reviewed changes
@alxgomz alxgomz requested review from gionn and pmacius February 13, 2025 14:09
gionn
gionn reviewed Feb 13, 2025
View reviewed changes
pmacius
pmacius reviewed Feb 13, 2025
View reviewed changes
@alxgomz alxgomz requested review from gionn and pmacius February 13, 2025 16:00
gionn
gionn reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check tests because they are currently broken

@gionn gionn removed the request for review from pmacius February 14, 2025 14:09
@alxgomz alxgomz added the ec2-test Triggers ec2 integrations tests label Feb 17, 2025
gionn
gionn requested changes Feb 17, 2025
View reviewed changes
@alxgomz alxgomz requested review from gionn and pmacius February 17, 2025 12:29
pmacius
pmacius previously approved these changes Feb 17, 2025
View reviewed changes
gionn
gionn reviewed Feb 17, 2025
View reviewed changes
pmacius
pmacius reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove acc versions from community extra vars

@alxgomz alxgomz requested review from gionn and pmacius February 17, 2025 15:09
alxgomz and others added 24 commits February 17, 2025 16:15
@alxgomz
use acc_* vars in molecule role test and playbook
dcd3ad6
@alxgomz
add acc vars in acs74 var file
3007efe
@alxgomz
remove acc avrs from all groups vars and extravars files
ef6c151
@alxgomz
add adw vars in version based vars files
bfa9e97
@alxgomz
use new adw vars in plays
9a7b8a2
@alxgomz
ci - run pki scenario only in enterprise for now
cac0fbb
@alxgomz
playbooks/acs - fix up installed components file
ac6261f
@alxgomz
remove old adw vars from grou_vars/all & extravar files
f4f09cc
@alxgomz
roles/adf_app - move molecule test vars to converge playbook
e0ae704
@alxgomz
move common adf vars to group vars
857fb29
@alxgomz
move adf var from inventory group vars to playbook group vars
8f4f017
@alxgomz
ignore pipenv jython cache folder
a4742bc
@alxgomz
roles/adf_app - add a timeout variable for download
e0c5abe
@alxgomz
review comments
1e4dee1
@alxgomz
switch from role dependencies to explicit include_role
3c85593
@alxgomz
use proper var prefix in nginx (role dependency)
3fddc14
@alxgomz
use version_specific_ prefix for vars/acs* vars
4a376f0
@alxgomz
roles/adf_app - remove fetc entrypoint
cf342fe
@alxgomz
roles/adf_app - revert to meta dependencies definitions
24fa9b7
@alxgomz
change var prefix from version_specific_ to acs_play
3bda48d
@alxgomz
use adf acs_play vars
7ec5b6b
@alxgomz @gionn
fix adw@acs73 version
581977a 
Co-authored-by: Giovanni Toraldo <[email protected]>
@alxgomz
rename mutualised acc_ & adw_ vars as well
67f162a
@alxgomz
review comment
077e901
pmacius
pmacius approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alxgomz alxgomz merged commit c13f39a into master Feb 18, 2025
70 checks passed
@alxgomz alxgomz deleted the OPSEXP-3042 branch February 18, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gionn gionn gionn approved these changes

@pmacius pmacius pmacius approved these changes

Assignees

No one assigned

Labels

ec2-test Triggers ec2 integrations tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alxgomz @gionn @pmacius