OPSEXP-3052 Refactor trouter role to use default vars #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
previously approved these changes
Feb 20, 2025
alxgomz
reviewed
Feb 20, 2025
Contributor
alxgomz
left a comment
alxgomz
left a comment
There was a problem hiding this comment.
So in the end do we stick to trouter_zip_*variable names even for jars?
Contributor
Author
|
@alxgomz I was thinking to change the vars to something more consistent for all roles after we end the current loop of PRs |
alxgomz
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: OPSEXP-3052