Skip to content

OPSEXP-3044: pass java_version as an argument for roles depending on java #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alxgomz merged 2 commits into from
Feb 20, 2025
Merged

OPSEXP-3044: pass java_version as an argument for roles depending on java #1083

alxgomz merged 2 commits into from
Feb 20, 2025

Conversation

@alxgomz
Copy link
Contributor

@alxgomz alxgomz commented Feb 19, 2025

@alxgomz alxgomz force-pushed the OPSEXP-3044-java-version-arg branch 5 times, most recently from 3037c15 to 3d831b6 Compare February 19, 2025 18:35
@alxgomz alxgomz added the ec2-test Triggers ec2 integrations tests label Feb 19, 2025
@alxgomz alxgomz requested review from gionn and pmacius and removed request for pmacius February 19, 2025 20:03
pmacius
pmacius previously approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For java taks that should be enough but I was thinking that we probably should move everything to import_role to be consistent. Check that error on opensearch scenario not sure if thats some flaky test

@alxgomz alxgomz force-pushed the OPSEXP-3044-java-version-arg branch from 3d831b6 to 4948767 Compare February 20, 2025 09:10
gionn
gionn previously approved these changes Feb 20, 2025
View reviewed changes
@alxgomz alxgomz force-pushed the OPSEXP-3044-java-version-arg branch from 4948767 to e4fc8b0 Compare February 20, 2025 09:22
@alxgomz alxgomz force-pushed the OPSEXP-3044-java-version-arg branch from e4fc8b0 to 78be5f1 Compare February 20, 2025 12:54
@alxgomz alxgomz merged commit 87dba34 into master Feb 20, 2025
70 checks passed
@alxgomz alxgomz deleted the OPSEXP-3044-java-version-arg branch February 20, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmacius pmacius pmacius approved these changes

@gionn gionn gionn left review comments

Assignees

No one assigned

Labels

ec2-test Triggers ec2 integrations tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alxgomz @gionn @pmacius