OPSEXP-3231 Integrate the new hxi_connector role #1164
Conversation
gionn
force-pushed
the
OPSEXP-3231-hxi-role
branch
from
50c76c3 to
37b82da
Compare
gionn
force-pushed
the
OPSEXP-3231-hxi-role
branch
from
0c64fd8 to
f9afe52
Compare
gionn
force-pushed
the
OPSEXP-3231-hxi-role
branch
from
d805a76 to
574689e
Compare
gionn
force-pushed
the
OPSEXP-3231-hxi-role
branch
from
5fd9dd8 to
514c6b8
Compare
pmacius
left a comment
pmacius
left a comment
There was a problem hiding this comment.
Mention something about integrating dynamic-facts.yml into facts.yml in merge commit
alxgomz
left a comment
alxgomz
left a comment
There was a problem hiding this comment.
LGTM overall, just a few comments
playbooks/acs.yml
Outdated
| - name: Include HxInsight vars | ||
| ansible.builtin.include_vars: | ||
| file: ../vars/hxi.yml |
There was a problem hiding this comment.
It's probably safe to use a var_files at the play level instead or plain set_facts tasks
There was a problem hiding this comment.
here could be possible as the conditional in the task is not necessary, but maybe I prefer staying with the task to be consistent with the repository play
playbooks/acs.yml
Outdated
| repository_truststore_type: "{{ acs_play_default_truststore_type }}" | ||
| - name: Include HxInsight vars | ||
| ansible.builtin.include_vars: | ||
| file: ../vars/hxi.yml |
There was a problem hiding this comment.
It's probably safe to use a var_files at the play level instead or plain set_facts tasks
There was a problem hiding this comment.
there is a conditional, which can be applied only to a task.
not sure ho set_facts can help here, hxi.yml contains configuration for hxinsight the user is meant to provide manually
just realized that I didn't write a single docs about this
OPSEXP-3231