OPSEXP-3233 Fix jdbc driver class not propagated to repo/sync roles

[gionn]

Fix #1171 OPSEXP-3233

[jalvarezferr]

Shouldn't group_vars of repository and syncservice set the driver class value based on the values of acs_play_repo_db_driver and acs_play_sync_db_driver respectively?

repository.yml:

acs_play_repository_jdbc_driver_class: "{{ acs_play_repo_db_driver | default(default_jdbc_pg_driver_class) }}"

syncservice.yml:

acs_play_sync_jdbc_driver_class: "{{ acs_play_sync_db_driver | default(default_jdbc_pg_driver_class) }}"

Without that, unless we explicitly set acs_play_repository_jdbc_driver_class and acs_play_sync_jdbc_driver_class in extra vars, the role will receive the group_vars values which will be aqain the default (for PostgreSQL). In our previous solution this did not happen as repository_jdbc_driver_class was not propagated and we fixed it in the defaults of the role.

The change made to the deployment document, indicating to set acs_play_repository_jdbc_driver_class directly, does not comply with the naming convention of all other external variables. With the change I mention the external variable would remain as it was.

[gionn]

what was really confusing me is that both:

• acs_play_repository_jdbc_driver_class
• acs_play_sync_jdbc_driver_class

are defined as group_vars for their respective groups but never really used.

So I decided to simply get rid of them and make sure the previous acs_play_repo_db_driver and acs_play_sync_db_driver are properly propagated to their respective role arguments.