Skip to content

Conversation

@gionn
Copy link
Member

@gionn gionn commented May 23, 2025

@gionn gionn self-assigned this May 23, 2025
@gionn gionn requested review from alxgomz and removed request for alxgomz May 23, 2025 14:39
@gionn gionn changed the title OPSEXP-3253 Add venv requirement for python 3.12+ OPSEXP-3253 Document workaround for pipenv on Ubuntu 24.04 for Python 3.12 May 26, 2025
@gionn gionn requested review from a team, alxgomz, Copilot and pmacius May 26, 2025 10:49
@gionn gionn force-pushed the OPSEXP-3253-venv branch from 63ba363 to 92510bf Compare May 26, 2025 10:50

This comment was marked as outdated.

@gionn gionn requested a review from Copilot May 26, 2025 10:58

This comment was marked as outdated.

@gionn gionn marked this pull request as ready for review May 26, 2025 11:02
pmacius
pmacius previously approved these changes May 26, 2025
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gionn gionn requested review from Copilot and pmacius May 26, 2025 12:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Python 3.12 on Ubuntu 24.04 by installing pipenv via apt, updates related documentation, and bumps the default ACS major version.

  • Introduce conditional pipenv installation for Ubuntu 24.04 in the Vagrant provision script.
  • Rename and extend documentation sections for “Setup Python runtime,” including a workaround for pipenv on Python 3.12.
  • Update Vagrantfile to default ACS major version from 23 to 25.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
scripts/vagrant_provision.sh Adjust shebang; add Ubuntu 24.04 check to install pipenv package instead of pip.
docs/playbook-upgrade.md Update link to point at the renamed “Setup Python runtime” section.
docs/deployment-guide.md Rename “Setup runtime environment” to “Setup Python runtime” and add pipenv workaround.
Vagrantfile Bump default VAGRANT_ACS_MAJOR_VERSION from 23 to 25.
Comments suppressed due to low confidence (2)

docs/deployment-guide.md:21

  • The link fragment omits a hyphen between 'ubuntu' and 'debian', so it won’t match the generated heading ID. It should be '#additional-requirements-for-python-312-on-ubuntu-debian'.
*      * [Additional requirements for Python 3.12+ on Ubuntu/Debian](#additional-requirements-for-python-312-on-ubuntudebian)

scripts/vagrant_provision.sh:1

  • [nitpick] The '-x' flag was removed from the shebang, so the script will no longer print commands during execution. Confirm whether verbose tracing is still desired for debugging provision failures.
#!/bin/bash -e

@gionn gionn merged commit 20f2c80 into master May 27, 2025
64 checks passed
@gionn gionn deleted the OPSEXP-3253-venv branch May 27, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants