-
Notifications
You must be signed in to change notification settings - Fork 33
OPSEXP-3253 Document workaround for pipenv on Ubuntu 24.04 for Python 3.12 #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <[email protected]>
pmacius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Python 3.12 on Ubuntu 24.04 by installing pipenv via apt, updates related documentation, and bumps the default ACS major version.
- Introduce conditional pipenv installation for Ubuntu 24.04 in the Vagrant provision script.
- Rename and extend documentation sections for “Setup Python runtime,” including a workaround for pipenv on Python 3.12.
- Update Vagrantfile to default ACS major version from 23 to 25.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/vagrant_provision.sh | Adjust shebang; add Ubuntu 24.04 check to install pipenv package instead of pip. |
| docs/playbook-upgrade.md | Update link to point at the renamed “Setup Python runtime” section. |
| docs/deployment-guide.md | Rename “Setup runtime environment” to “Setup Python runtime” and add pipenv workaround. |
| Vagrantfile | Bump default VAGRANT_ACS_MAJOR_VERSION from 23 to 25. |
Comments suppressed due to low confidence (2)
docs/deployment-guide.md:21
- The link fragment omits a hyphen between 'ubuntu' and 'debian', so it won’t match the generated heading ID. It should be '#additional-requirements-for-python-312-on-ubuntu-debian'.
* * [Additional requirements for Python 3.12+ on Ubuntu/Debian](#additional-requirements-for-python-312-on-ubuntudebian)
scripts/vagrant_provision.sh:1
- [nitpick] The '-x' flag was removed from the shebang, so the script will no longer print commands during execution. Confirm whether verbose tracing is still desired for debugging provision failures.
#!/bin/bash -e
OPSEXP-3253