OPSEXP-3273 Migrate search testinfra tests to ansible with search tests #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gionn
changed the title
gionn
reviewed
Jun 19, 2025
alxgomz
reviewed
Jun 19, 2025
alxgomz
previously requested changes
Jun 19, 2025
Contributor
alxgomz
left a comment
alxgomz
left a comment
There was a problem hiding this comment.
Please remove the older test file, that'll make the PR easier to review as one can directly compare older and newer tests
pmacius
approved these changes
Jun 24, 2025
Contributor
pmacius
left a comment
pmacius
left a comment
There was a problem hiding this comment.
LGTM after applying Gio suggestion
gionn
approved these changes
Jun 25, 2025
ffjdm
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will migrate python module(testinfra) to test ansible roles, testinfra which is no more an available verifier in molecule.
[Removal of testinfra verifier · Issue #3920 https://github.com/https://github.com/ansible/molecule/issues/3920
we will migrate testinfra (python-based) to ansible tasks.
Related Issue
OPSEXP-3273
Changes introduced
Removed Python-based Testinfra tests (roles/search/molecule/default/verify.yml)
Replaced with Ansible assert tasks in the verify.yml