Skip to content

Conversation

@gionn
Copy link
Member

@gionn gionn commented Jun 18, 2025

build where failing more often than usual and realized the cache was outdated

OPSEXP-3298

@gionn gionn self-assigned this Jun 18, 2025
@gionn gionn force-pushed the fixup-download-cache-invalidation branch from 7a848f5 to 27a8db9 Compare June 18, 2025 14:26
@gionn gionn force-pushed the fixup-download-cache-invalidation branch from 27a8db9 to 9736afd Compare June 18, 2025 14:31
@gionn gionn requested review from a team, alxgomz, Copilot, ffjdm, pmacius and siddavamshi4 June 18, 2025 14:53
@gionn gionn marked this pull request as ready for review June 18, 2025 14:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the composite action to invalidate the downloaded artifacts cache whenever the ActiveMQ or Tomcat versions change.

  • Peeks activemq_version and tomcat_version from their role defaults
  • Updates the cache key to include those version values
  • Removes the previous group_vars/all.yml hash and keeps the prefetch-artifacts hash
Comments suppressed due to low confidence (3)

.github/actions/cache-downloads/action.yml:18

  • The yq command may include quotes in its output which can result in quotes being embedded in the cache key. Consider using yq with the -r flag (e.g., yq -r '.activemq_version' ...) to produce raw, unquoted values.
        echo "activemq_version=$(yq '.activemq_version' roles/activemq/defaults/main.yml)" >> $GITHUB_OUTPUT

.github/actions/cache-downloads/action.yml:33

  • The indentation before "mq" will be included in the cache key string due to the backslash continuation, introducing unintended leading spaces. Remove the extra whitespace or align the backslashes without indentation.
          mq${{ steps.activemq_peek.outputs.activemq_version }}-\

.github/actions/cache-downloads/action.yml:32

  • [nitpick] Splitting the cache key string with backslash escapes is harder to read and maintain. Consider using YAML’s folded block scalar (>-) or a single-line string for improved clarity.
        key: "cache-downloads-v${{ inputs.cache-version }}-${{ inputs.cache-name }}-\

@gionn gionn changed the title Workaround the downloaded artifacts cache invalidation OPSEXP-3298 Workaround the downloaded artifacts cache invalidation Jun 18, 2025
@gionn gionn merged commit 10a8348 into master Jun 18, 2025
93 of 94 checks passed
@gionn gionn deleted the fixup-download-cache-invalidation branch June 18, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants