OPSEXP-2826 Run apply_amps script only when needed #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
reviewed
Aug 5, 2025
gionn
changed the title
gionn
previously approved these changes
Aug 6, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the Ansible repository role to only run the apply_amps.sh script when AMP configuration changes are detected, preventing unnecessary execution on subsequent runs.
- Introduces checksum-based change detection for AMP configurations
- Conditionally executes the
apply_amps.shscript only when needed - Adds checksum file storage to track configuration state between runs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| roles/repository/tasks/main.yml | Implements checksum generation, comparison logic, and conditional execution of AMP installation |
| roles/repository/defaults/main.yml | Adds default path for the AMP checksum file |
gionn
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: OPSEXP-2826