OPSEXP-2880 Add audit-storage role #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
force-pushed
the
OPSEXP-2880-audit-storage
branch
from
eed77e9 to
6258361
Compare
gionn
force-pushed
the
OPSEXP-2880-audit-storage
branch
from
6258361 to
515bffc
Compare
gionn
force-pushed
the
OPSEXP-2880-audit-storage
branch
from
6ed42e6 to
587c44c
Compare
gionn
force-pushed
the
OPSEXP-2880-audit-storage
branch
from
587c44c to
de5e01a
Compare
gionn
changed the title
pmacius
previously approved these changes
Nov 28, 2024
Contributor
pmacius
left a comment
pmacius
left a comment
There was a problem hiding this comment.
Are we disabling this role for older version?
Member
Author
good catch, let me add an explicit validation for that |
gionn
force-pushed
the
OPSEXP-2880-audit-storage
branch
from
33a1f98 to
fd59dbe
Compare
pmacius
reviewed
Nov 29, 2024
Contributor
pmacius
left a comment
pmacius
left a comment
There was a problem hiding this comment.
We can bump dtas version to v1.6.0 and configure tests for audit-storage
gionn
force-pushed
the
OPSEXP-2880-audit-storage
branch
from
fbc964c to
4df8a0a
Compare
alxgomz
reviewed
Dec 2, 2024
alxgomz
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPSEXP-2880