checker: suite no bare testing.T #247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaraldNordgren
changed the title
HaraldNordgren
force-pushed
the
suite_no_testing_t
branch
from
55e8839 to
987f845
Compare
|
Ping @Antonboom, can I get some review here please? 🤗 |
HaraldNordgren
changed the title
|
Hi, @HaraldNordgren Thank you for contribution! Looks like improvement of #suite-method-signature or #suite-dont-use-pkg and not a separate checker. In the next time I recommend to make issue first to avoid the extra work 🙂 What are your thoughts after taking into account the logic of the two checkers above? |
|
Hi @Antonboom! Sorry I missed this, I changed my GitHub email routing and lost my email notifications for this thread 😬 I would suggest we put it in Is it in any way a concern for you that one of these two previous checkers become too bloated after adding this functionality? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create checker to make sure that
suitemethods are not passing a baretesting.T.