Skip to content

#2243 function expression as rhs in assignment #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2022
Merged

#2243 function expression as rhs in assignment #2255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b35a2d7
fix: #2243 function expression as rhs
technohippy Apr 8, 2022
34d1c1a
add name
technohippy Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ under the licensing terms detailed in LICENSE:
* Felipe Gasper <[email protected]>
* Congcong Cai <[email protected]>
* mooooooi <[email protected]>
* Yasushi Ando <[email protected]>

Portions of this software are derived from third-party works licensed under
the following terms:
Expand Down
2 changes: 1 addition & 1 deletion src/bindings/js.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,7 @@ export class JSBuilder extends ExportsWalker {
/** Lifts a WebAssembly value to a JavaScript value. */
makeLiftFromValue(name: string, type: Type, sb: string[] = this.sb): void {
if (type.isInternalReference) {
const clazz = assert(type.getClass());
const clazz = assert(type.getClassOrWrapper(this.program));
if (clazz.extends(this.program.arrayBufferInstance.prototype)) {
sb.push("__liftBuffer(");
this.needsLiftBuffer = true;
Expand Down
2 changes: 1 addition & 1 deletion src/bindings/tsd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ export class TSDBuilder extends ExportsWalker {
toTypeScriptType(type: Type, mode: Mode): string {
if (type.isInternalReference) {
const sb = new Array<string>();
const clazz = assert(type.getClass());
const clazz = assert(type.getClassOrWrapper(this.program));
if (clazz.extends(this.program.arrayBufferInstance.prototype)) {
sb.push("ArrayBuffer");
} else if (clazz.extends(this.program.stringInstance.prototype)) {
Expand Down