Update jade to latest 1.11.0 due to security bug #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is security bug in uglyfy-js <= 2.4.23 (https://nodesecurity.io/advisories/uglifyjs_incorrectly_handles_non-boolean_comparisons) Here is full dependancy tree: Found in sub-dependency: kue (0.9.6) → jade (1.1.5) → transformers (2.1.0) → uglify-js (2.2.5) So updating jade to latest version to latest removed this security bug in kue as well.
behrad
added a commit
that referenced
this pull request
Nov 2, 2015
Update jade to latest 1.11.0 due to security bug
Collaborator
|
thank you @kolarski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is security bug in uglify-js
<= 2.4.23(https://nodesecurity.io/advisories/uglifyjs_incorrectly_handles_non-boolean_comparisons)Here is the full dependency tree:
kue (0.9.6) → jade (1.1.5) → transformers (2.1.0) → uglify-js (2.2.5)So updating jade to the latest version removed this security bug in kue as well.