Fix logic in attempts remaining check #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I've also seen the same, some race is causing more than max attempts (unlimited attempts even for failing jobs). Would you please investigate more to see if it still happens? Thank you @parkan |
Contributor
Author
|
Yeah, empirically this seems to happen with jobs that are likely to fail after an unclear amount of time (http requests against old links) and TTL being set |
behrad
added a commit
that referenced
this pull request
Nov 4, 2015
Fix logic in attempts remaining check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A race condition in our app was causing some jobs to be failed twice, bringing
Job._attemptsbelow 0, which resulted in the truthiness check-1 ?...below passing and the job being retried indefinitely. I'm still trying to track down the race condition, but this fix appears to prevent that behavior.