Converting Job ids back into integers #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zid field is a string, so we need to do a type conversion.
Contributor
Author
|
Fix for issue #845 |
id's should be numbers now.
Contributor
|
@hockeytim11, do you know if this issue made any functional issue? We often have jobs on queues that are paused for days or weeks, and just want to make sure that taking this change isn't going to cause any issues with those jobs. |
Contributor
Author
|
As far as I know, this issue should not have effected processing. The only issue was that job ID's were being returned as strings in the event handlers. The reason it was an issue for me was some tests on my project that used strict comparisons of the job results on the complete event. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zid field is a string, so we need to do a type conversion.