fix: avoid minimizing single nested subdocs if they are required #14151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14058
Summary
#14058 pointed out an unfortunate issue with the fix for #11247:
required
subdocuments without defaults end up getting minimized out, which leads to errors on subsequent saves by default unless you use thevalidateBeforeSave: false
option forsave()
. This behavior is very unintuitive. With this PR, we'll skip minimizing subdocuments that haverequired
set to a truthy value, including functions. So still works as expected if notrequired
.Examples