Skip to content

types: fix definition of VectorSearch.$vectorSearch #15429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2025
Merged

types: fix definition of VectorSearch.$vectorSearch #15429

merged 1 commit into from
May 25, 2025

Conversation

chriskrycho
Copy link
Contributor

Summary

The exact field was missing from the interface, and the numCandidates field was typed as required. Neither of these match the docs.

Examples

Previously, any use of the interface that directly used an object literal with exact: true, or any version that omitted numCandidates would fail.

@vkarpov15 vkarpov15 requested a review from Copilot May 25, 2025 18:25
Copilot
Copilot AI reviewed May 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@vkarpov15 vkarpov15 merged commit 03a00b2 into Automattic:master May 25, 2025
4 checks passed
@vkarpov15 vkarpov15 modified the milestones: 8.16, 8.15.1 May 25, 2025
@chriskrycho chriskrycho deleted the vector-types branch May 29, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@chriskrycho @vkarpov15