Ensure update validators only call validators underneath single nested paths once #15446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses issue #15436 by ensuring that update validators for single nested paths are only called once.
- Added tests to verify the behavior for both type casting and update validation in nested documents.
- Updated the update validators helper to mark single nested paths as already validated.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/types/models.test.ts | Added a test function (gh15437) to validate schema hydration. |
| test/model.updateOne.test.js | Introduced a new test ensuring validators under single nested docs are called only once. |
| lib/helpers/updateValidators.js | Updated logic to flag single nested paths as already validated. |
AbdelrahmanHafez
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15436
Summary
Examples