fix(DocumentArray): correctly set parent if instantiated with schema from another Mongoose instance

[vkarpov15]

Summary

#15466 points out that Mongoose throws an unreadable error if creating a document array that was defined with Schema() from a different Mongoose instance.

I added tests to cover this case automatically - historically we haven't tested the multiple require() instance setup, but we should since it is so common.

Examples

[Copilot]

Pull Request Overview

This PR ensures that document arrays defined with schemas from a different Mongoose instance correctly set their parent, adds tests for that scenario, and configures CI to simulate multiple require('mongoose') instances.

• Replace instanceof Document checks with a duck‐typing check on doc.$__ for both DocumentArray and MongooseArray.
• Add a dedicated test covering document arrays using schemas from a separate instance.
• Introduce a helper script and CI step to create and test against a separate Mongoose require instance.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/multiple-require-instance.test.js	New test for document arrays instantiated with schemas from a separate Mongoose instance
package.json	Add create-separate-require-instance script to populate mongoose-separate-require-instance
.github/workflows/test.yml	Invoke the new script before running tests in CI
lib/types/documentArray/index.js	Use if (doc && doc.$__) instead of instanceof Document to set array parent
lib/types/array/index.js	Apply the same doc.$__ check for plain arrays

Comments suppressed due to low confidence (4)

lib/types/documentArray/index.js:54

• [nitpick] Add a comment explaining why the doc.$__ check is used instead of instanceof Document to clarify the intent and any edge cases this change addresses.

if (doc && doc.$__) {

.github/workflows/test.yml:71

• The script uses rm -rf which is not cross-platform and will fail on Windows agents. Consider using a cross-platform cleanup tool like rimraf or a Node.js script to remove directories.

-      - run: npm run create-separate-require-instance

test/multiple-require-instance.test.js:20

• Add a complementary test to cover native arrays (non-document arrays) defined with schemas from a separate instance so the MongooseArray logic is verified as well.

it('supports arrays defined using schemas from separate instance (gh-15466)', async function() {

lib/types/documentArray/index.js:56

• The arraySchemaSymbol is retrieved via doc.$__schema, whereas in lib/types/array/index.js you use the public doc.schema. For clarity and consistency, align both modules to reference doc.schema.

internals[arraySchemaSymbol] = doc.$__schema.path(path);

[AbdelrahmanHafez]

LGTM 👍