Use new Telemetry class from VIP mu-plugins #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this PR in WordPress Playground. |
maxschmeling
approved these changes
Apr 11, 2025
| add_action( 'save_post', [ $this, 'track_remote_data_blocks_usage' ], 10, 2 ); | ||
|
|
||
| // Custom hook to allow other plugin code to track events | ||
| add_action( 'remote_data_blocks_track_event', [ $this, 'record_event' ], 10, 2 ); |
There was a problem hiding this comment.
We're inconsistent between the action and the EVENT_PREFIX value (remote_data_blocks vs remotedatablocks)
Any reason we can't make those consistent?
There was a problem hiding this comment.
Most of the namespacing we've done in the WordPress plugin uses remote_data_blocks. However, Tracks is external to WordPress and the event names were already registered months ago using remotedatablocks as the prefix. It's a bit painful to change, otherwise I would have done it.
inc/Telemetry/Telemetry.php
Outdated
| * @param string $event_name The name of the event. | ||
| * @param array $props The properties to send with the event. | ||
| * | ||
| * @return bool True if the event was recorded, false otherwise. |
chriszarate
commented
Apr 11, 2025
Co-authored-by: Max Schmeling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
Telemetryclass from VIP mu-plugins. This class abstracts away many of the checks that were being performed in this plugin, and as a result we can remove a large amount of code.I also renamed
TracksTelemetrytoTelemetrysince it is no longer pinned to that service. Note that much of the code, includingtrack_remote_data_blocks_usageis unchanged.I've also added an integration test to cover this work.