Use a label to highlight the connected block #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingeniumed
changed the title
|
Test this PR in WordPress Playground. |
ingeniumed
commented
Apr 11, 2025
| title={ sprintf( __( 'Remote Data Block: %s', 'remote-data-blocks' ), remoteDataTitle ) } | ||
| > | ||
| <PanelBody title={ __( 'Remote Data', 'remote-data-blocks' ) }> | ||
| <p style={ { fontSize: 'small', color: 'rgb(117, 117, 117)' } }> |
There was a problem hiding this comment.
The fontSize and colour are used to replicate the Gutenberg helper text shown on a lot of their components. Unfortunately, PanelBody doesn't have help as an option on it so this is the only way to show it.
I have set the fontSize to be small, and set the colour to be the same within the helper text. If anyone has a better suggestion, I'm happy to update this.
There was a problem hiding this comment.
Can this be targeted with a className instead of inline style?
There was a problem hiding this comment.
Done in the latest commit 👍🏾
chriszarate
approved these changes
Apr 11, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is meant to incorporate the feedback from @jarekmorawski, to build on #443. It does the following:
Remote Data