-
Notifications
You must be signed in to change notification settings - Fork 7
Remove Psr\Log
, add "Logs" Query Monitor subpanel
#493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test this PR in WordPress Playground. |
alecgeatches
reviewed
May 2, 2025
@alecgeatches Thanks, fixed in 6dec67b |
alecgeatches
approved these changes
May 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looking good!
ingeniumed
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Psr\Log
. We ran into type hint conflicts when adding this plugin to some internal sites. Those sites used plugins with their own (older and incompatible) version ofPsr\Log
. Since it's likely that other users might hit this same issue, we will remove this library and provide a small implementation of our own.wpcomvip_log_to_query_monitor
action, since we now log to Query Monitor in our own panel.wpcomvip_log
action toremote_data_blocks_log
.