Skip to content

Remove whitespace #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Remove whitespace #557

merged 1 commit into from
May 28, 2025

Conversation

pkevan
Copy link
Contributor

@pkevan pkevan commented May 20, 2025

Otherwise, the output generate looks like this:

Screenshot 2025-05-20 at 16 59 17

@pkevan pkevan requested a review from a team as a code owner May 20, 2025 15:59
@pkevan pkevan requested review from ingeniumed and removed request for a team May 20, 2025 15:59
@github-actions GitHub Actions
Copy link
Contributor

Test this PR in WordPress Playground.

chriszarate
chriszarate approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@chriszarate chriszarate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the regex also needs adjustment. The tab before $data_source = is getting mangled for some reason. But this fix can be shipped

@ingeniumed ingeniumed merged commit 4cedff5 into trunk May 28, 2025
13 checks passed
@ingeniumed ingeniumed deleted the fix/remove-whitespace-http-template branch May 28, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriszarate chriszarate chriszarate approved these changes

@ingeniumed ingeniumed Awaiting requested review from ingeniumed ingeniumed is a code owner automatically assigned from Automattic/vip-cafe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkevan @chriszarate @ingeniumed