Fix Block Bindings source label was overridden warning #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingeniumed
commented
May 30, 2025
| @@ -2,7 +2,7 @@ import { registerBlockBindingsSource } from '@wordpress/blocks'; | |||
|
|
|||
| registerBlockBindingsSource( { | |||
| name: 'remote-data/binding', | |||
| label: 'Remote Data Binding', | |||
| label: 'Remote Data Blocks', | |||
There was a problem hiding this comment.
Don't mind changing the PHP code instead of Remote Data Binding, but feel like Remote Data Blocks will make more sense to someone than Remote Data Bindings as they know the plugin.
|
Test this PR in WordPress Playground. |
chriszarate
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there is a warning being spat out by the plugin every time a post is loaded in the editor that looks as follows:
This is because our label is different between the PHP and TS code. So I've united this to be
Remote Data Blocksjust like it is on the PHP code.