Fix bug in request details filter, and update preprocess response #595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is meant to update the
request_details
filter, to not overwrite thequery
with a string representation of thequery params
. Also, this implements a possible solution for the problem identified in #594 - remove theinput_variables
and replace it withrequest_details
instead. Therequest_details
is used to store therow_id
in the headers if by the Google Sheets data source and then the filter is used to inject this in the pre-process response. This allows for the cache to work as expected, and for the query to return the correct response as well.Testing
query Inputs panel
should reflect this as well.