Skip to content

Fix bug in request details filter, and update preprocess response #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

ingeniumed
Copy link
Contributor

Description

This PR is meant to update the request_details filter, to not overwrite the query with a string representation of the query params. Also, this implements a possible solution for the problem identified in #594 - remove the input_variables and replace it with request_details instead. The request_details is used to store the row_id in the headers if by the Google Sheets data source and then the filter is used to inject this in the pre-process response. This allows for the cache to work as expected, and for the query to return the correct response as well.

Testing

  • Setup a Google Sheets data source
  • Insert a block for this data source
  • Ensure this works as expected by picking a few entries, and ensuring they show up correctly
  • Updating the row ID in the query Inputs panel should reflect this as well.

@ingeniumed ingeniumed requested a review from a team as a code owner June 12, 2025 02:41
@ingeniumed ingeniumed requested review from alecgeatches and removed request for a team June 12, 2025 02:41
Copy link
Contributor

Test this PR in WordPress Playground.

@ingeniumed ingeniumed requested a review from chriszarate June 12, 2025 02:42
@ingeniumed ingeniumed self-assigned this Jun 12, 2025
@ingeniumed ingeniumed merged commit ce94589 into trunk Jun 12, 2025
13 checks passed
@ingeniumed ingeniumed deleted the update/bug-fix-for-data-source branch June 12, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants