Skip to content

fix: Selecting multiple lines in RTL textbox #19093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AhmedZero
Copy link

@AhmedZero AhmedZero commented Jun 21, 2025

What does the pull request do?

fixes #19046, This PR modifies the text layout system to properly handle Right-to-Left (RTL) languages while maintaining existing Left-to-Right (LTR) support.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

fixes #19046

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 12.0.999-cibuild0057191-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented Jun 21, 2025

  • All contributors have signed the CLA.

@AhmedZero
Copy link
Author

@cla-avalonia agree

@MrJul
Copy link
Member

MrJul commented Jun 23, 2025

Thank you for your contribution!
This needs some unit tests to better understand the fixed issue (and make sure we won't regress it in the future).

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 12.0.999-cibuild0057219-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 12.0.999-cibuild0057223-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald
Copy link
Contributor

Please make the new test a theory and add some RTL text and mixed text to verify this is working with bidi text.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 12.0.999-cibuild0057261-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting multiple lines Causes App Freeze and Memory Leak
5 participants