chore: Fix and reenable fees-settings test #12302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
reviewed
Feb 26, 2025
| @@ -47,7 +47,10 @@ export class GasTxValidator implements TxValidator<Tx> { | |||
| maxFeesPerGas.feePerL2Gas.lt(this.#gasFees.feePerL2Gas); | |||
|
|
|||
| if (notEnoughMaxFees) { | |||
| this.#log.warn(`Skipping transaction ${tx.getTxHash()} due to insufficient fee per gas`); | |||
| this.#log.warn(`Skipping transaction ${await tx.getTxHash()} due to insufficient fee per gas`, { | |||
There was a problem hiding this comment.
I suppose the alternative to this making the whole func async would be to kick this off as an async side-effect. But perhaps would get weird
There was a problem hiding this comment.
The caller was already async, so I didn't worry too much
ludamad
approved these changes
Feb 26, 2025
spalladino
added a commit
that referenced
this pull request
Feb 26, 2025
This reverts commit dbcb2b1.
TomAFrench
added a commit
that referenced
this pull request
Feb 26, 2025
* master: (31 commits) feat: Slack message to ci channel tagging owners on flakes. (#12284) fix: slack notify was broken by quoted commit titles revert: "chore: Fix and reenable fees-settings test (#12302)" fix: run arm64 on master (#12307) yolo fix chore: Fix and reenable fees-settings test (#12302) feat!: rename compute_nullifier_without_context (#12308) chore: Lazy loading artifacts everywhere (#12285) chore: Reenable dapp subscription test (#12304) chore: Run prover test with fake proofs when requested (#12305) chore: Do not set CI_FULL outside CI (#12300) chore: new mnemonic deployments on sepolia (#12076) chore!: enable multiple L1 nodes to be used (#11945) chore: remove no longer supported extension from vscode/extension.json (#12303) fix(e2e): p2p_reqresp (#12297) feat: Sync from noir (#12298) chore: enabling `e2e_contract_updates` in CI + nuking irrelevant test (#12293) feat: prepend based merge (#12093) feat: fetch addresses from registry (#12000) feat: live logs (#12271) ...
PhilWindle
pushed a commit
that referenced
this pull request
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12258