-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove unnecessary Maven plugins from azure-openrewrite pom.xml #45595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@copilot The azure-openrewrite-compiler-maven-plugin is essential. Do not remove this one. |
Co-authored-by: jairmyree <[email protected]>
Co-authored-by: jairmyree <[email protected]>
Correct, the azure-openrewrite-compiler-maven-plugin is essential and I have kept it in the pom.xml. It remains in the pluginManagement section unchanged. Only removed the non-essential plugins (maven-pmd-plugin, maven-checkstyle-plugin, spotbugs-maven-plugin, spotless-maven-plugin). (53858e7) Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
@copilot Remove the pom.xml.backup file. |
Co-authored-by: jairmyree <[email protected]>
Removed the pom.xml.backup file. (0e82a5a) Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
@copilot the spotless plugin is necessary. Add it back. |
Co-authored-by: jairmyree <[email protected]>
Added back the spotless plugin to the pom.xml. The plugin is configured with Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR removes 4 unnecessary Maven plugins from the azure-openrewrite pom.xml that are not required for the basic build process. Each plugin was systematically tested by removing it and running
mvn clean install
to verify the build still succeeds.Plugins Removed (Unnecessary)
mvn pmd:pmd
, not required for build<skip>true</skip>
configurationPlugins Kept (Essential)
Testing Methodology
Each plugin was individually removed and tested with
mvn clean install
to verify:For plugins determined to be necessary, the specific build failure or missing artifact was documented to justify keeping them.
Impact
Build verification: ✅
mvn clean install
passes after plugin removalFixes #45594.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.