Rename symbol doesn't provide any feedback when it's done in an invalid location - it just doesn't do anything. C# has the same behavior as what I did, but TS produces a proper error.
In the LSP protocol spec, the rename response is supposed to be of type WorkspaceEdit | null. I suspect that null is used to signal a failure to the client, but the OmniSharp package doesn't let me return null (the request fails when I try). I also tried getting PrepareRename to work but the handler in OmniSharp doesn't work at all either. (Prepare rename is intended to validate whether a particular location is valid for rename and the protocol even allows returning errors back out.)
We should investigate and potentially fix this.
Rename symbol doesn't provide any feedback when it's done in an invalid location - it just doesn't do anything. C# has the same behavior as what I did, but TS produces a proper error.
In the LSP protocol spec, the rename response is supposed to be of type WorkspaceEdit | null. I suspect that null is used to signal a failure to the client, but the OmniSharp package doesn't let me return null (the request fails when I try). I also tried getting PrepareRename to work but the handler in OmniSharp doesn't work at all either. (Prepare rename is intended to validate whether a particular location is valid for rename and the protocol even allows returning errors back out.)
We should investigate and potentially fix this.