refactor: render Scriptless custom data only when necessary#1178
Merged
refactor: render Scriptless custom data only when necessary#1178
Conversation
tallaxes
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
The current if statement will result in Scriptless custom data being rendered in any mode except bootstrapping client provision mode. That works when only two modes exist. However, the new one is coming with Machine API integration. Not satisfying preconditions may result in errors during the rendering process, while having to worry about those are completely unnecessary in the first place.
How was this change tested?
Does this change impact docs?
Release Note