Skip to content

feat: Add NodeOverlay support#1238

Merged
tallaxes merged 12 commits intoAzure:mainfrom
hakman:node-overlay
Jan 7, 2026
Merged

feat: Add NodeOverlay support#1238
tallaxes merged 12 commits intoAzure:mainfrom
hakman:node-overlay

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Oct 27, 2025 •
edited
Loading

Fixes #

Description

Update Karpenter core to v1.7 to support Node Overlay and add support for it.
The PR is mostly based on aws/karpenter-provider-aws#8305 and adapted for Azure.

How was this change tested?

Manual testing.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

feat: Add NodeOverlay support (ALPHA)

hakman added 2 commits October 27, 2025 16:00
@hakman
chore: update Karpenter core to v1.7.1
e078f8a 
Signed-off-by: Ciprian Hacman <chacman@microsoft.com>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman
feat: Add NodeOverlay support
af56a4a 
Signed-off-by: Ciprian Hacman <chacman@microsoft.com>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman
chore: Fix tests
424bfd1 
Signed-off-by: Ciprian Hacman <chacman@microsoft.com>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@wdarko1 wdarko1 requested review from matthchr and tallaxes October 27, 2025 14:44
@hakman hakman force-pushed the node-overlay branch 2 times, most recently from 9703f8c to 6031979 Compare October 28, 2025 16:40
@wdarko1 wdarko1 mentioned this pull request Nov 5, 2025
Open
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Nov 27, 2025

@wdarko1 @tallaxes do you think this PR is going in the right direction, is there something that should be improved?

@hakman hakman force-pushed the node-overlay branch 2 times, most recently from 57bfda5 to d62ba89 Compare December 1, 2025 19:14
@hakman
chore: update Karpenter core to v1.7.1
a94ab9f 
Signed-off-by: Ciprian Hacman <chacman@microsoft.com>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman
feat: Add NodeOverlay support
f48454e 
Signed-off-by: Ciprian Hacman <chacman@microsoft.com>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
Signed-off-by: Ciprian Hacman <chacman@microsoft.com>
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Dec 15, 2025

PR rebased to address labels that were added in the mean time

tallaxes
tallaxes reviewed Jan 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in reviewing, looks good! Would strongly prefer E2E tests in the same PR, other than that should be ready to go.

I resolved merge conflicts with the changes on main that happened in the interim, but can't push to this branch since it also touches workflow; need to find a way to allow this, or re-resolve conflicts. For now captured in https://github.com/Azure/karpenter-provider-azure/tree/tallaxes/hackman/nodeoverlay

@hakman
Merge branch 'tallaxes/hackman/nodeoverlay' into node-overlay
5035613 
# Conflicts:
#	charts/karpenter-crd/templates/karpenter.sh_nodeoverlays.yaml
#	go.mod
#	go.sum
#	pkg/apis/crds/karpenter.sh_nodeoverlays.yaml
#	pkg/cloudprovider/suite_test.go
#	pkg/controllers/nodeclaim/garbagecollection/instance_garbagecollection.go
#	pkg/providers/instancetype/suite_test.go
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Jan 2, 2026

Thanks @tallaxes, I merged your branch, so hopefully fixes things.
I can try to add tests in a few weeks when I am back from vacation. I don't think it's that bad for now, as it's an alpha feature.

@tallaxes
Copy link
Copy Markdown
Collaborator

tallaxes commented Jan 3, 2026

@hakman I gave it a stab, added tests, PTAL 6a14ab8

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Jan 4, 2026

@hakman I gave it a stab, added tests, PTAL 6a14ab8

Thanks @tallaxes, LGTM!

tallaxes
tallaxes approved these changes Jan 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. E2E testing ran into unrelated issues which appear to be fixed by #1326. The latest E2E run on an equivalent branch has no relevant failures: https://github.com/Azure/karpenter-provider-azure/actions/runs/20735710345

@tallaxes tallaxes added area/api Issues or PRs related to the APIs area/core Issues related with karpenter-core/upstream labels Jan 6, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Jan 6, 2026

Nice, anything left before merging it?

@tallaxes tallaxes merged commit fa7d9dd into Azure:main Jan 7, 2026
17 checks passed
@marchermans
Copy link
Copy Markdown
Contributor

marchermans commented Jan 14, 2026

This is amazing.

Any idea when this will be released in an -rc or full release?

@hakman hakman deleted the node-overlay branch January 14, 2026 10:48
@wdarko1 wdarko1 added this to the 1.7.0 milestone Jan 28, 2026
@tallaxes tallaxes mentioned this pull request Feb 10, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthchr matthchr matthchr approved these changes

@tallaxes tallaxes tallaxes approved these changes

Assignees

No one assigned

Labels

area/api Issues or PRs related to the APIs area/core Issues related with karpenter-core/upstream

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@hakman @tallaxes @marchermans @matthchr @wdarko1