refactor: move AKS Machine provisioning state constants to consts module#1503
Merged
refactor: move AKS Machine provisioning state constants to consts module#1503
Conversation
Move ProvisioningState constants (Creating, Updating, Succeeded, Failed, Deleting) from string literals scattered across the codebase to pkg/consts/consts.go. This makes them shared and importable by any package, following existing codebase convention. Updated usages in: aksmachineinstance.go, aksmachineinstanceutils.go, aksmachineinstanceutils_test.go, fake/aksmachinesapi.go, test/aksagentpools.go, test/aksmachines.go. The VirtualMachine "Deleting" check in pkg/utils/utils.go is left as-is since it operates on armcompute.VirtualMachine, a different resource type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rakechill
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move AKS Machine provisioning state string literals to shared constants in
pkg/consts/consts.go. The Azure SDK'sMachine.Properties.ProvisioningStateis typed as*stringwith no typed constants, so we define our own (ProvisioningStateCreating,ProvisioningStateUpdating,ProvisioningStateSucceeded,ProvisioningStateFailed,ProvisioningStateDeleting).Replaces scattered string literals across
aksmachineinstance.go,aksmachineinstanceutils.go,fake/aksmachinesapi.go, and test helpers. Extracted from PR #1453 per reviewer request to keep PRs single-intention. PR #1453 (GET-based poller) is rebased on top of this.How was this change tested?
go build ./...passesgo test ./pkg/fake/... ./pkg/providers/instance/...all passgo vet ./...passes (pre-existing issue in hack/code only)Does this change impact docs?
Release Note