Merged
Conversation
matthchr
force-pushed
the
matthchr/skus-controller
branch
from
ce18199 to
69cd183
Compare
matthchr
force-pushed
the
matthchr/skus-controller
branch
from
69cd183 to
d84e4b6
Compare
tallaxes
approved these changes
Mar 17, 2026
3 tasks
comtalyst
added a commit
that referenced
this pull request
Mar 23, 2026
…goimports - Add UpdateInstanceTypes() calls to Ephemeral Disk BeforeEach/AfterEach in suite_features_test.go. These calls were present on main (added by #1536 instancetype controller) but lost when the reunification moved these tests from instancetype/suite_test.go before #1536 merged. The rebase added UpdateInstanceTypes to the old file location rather than the new one, causing NVMe placement tests to fail (instance types not refreshed after UseSIG context change). - Fix goimports formatting in suite_shared_provision_test.go (comment column alignment) and suite_test.go (missing blank line). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
comtalyst
added a commit
that referenced
this pull request
Mar 28, 2026
…goimports - Add UpdateInstanceTypes() calls to Ephemeral Disk BeforeEach/AfterEach in suite_features_test.go. These calls were present on main (added by #1536 instancetype controller) but lost when the reunification moved these tests from instancetype/suite_test.go before #1536 merged. The rebase added UpdateInstanceTypes to the old file location rather than the new one, causing NVMe placement tests to fail (instance types not refreshed after UseSIG context change). - Fix goimports formatting in suite_shared_provision_test.go (comment column alignment) and suite_test.go (missing blank line). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
comtalyst
added a commit
that referenced
this pull request
Mar 31, 2026
…goimports - Add UpdateInstanceTypes() calls to Ephemeral Disk BeforeEach/AfterEach in suite_features_test.go. These calls were present on main (added by #1536 instancetype controller) but lost when the reunification moved these tests from instancetype/suite_test.go before #1536 merged. The rebase added UpdateInstanceTypes to the old file location rather than the new one, causing NVMe placement tests to fail (instance types not refreshed after UseSIG context change). - Fix goimports formatting in suite_shared_provision_test.go (comment column alignment) and suite_test.go (missing blank line). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How was this change tested?
Does this change impact docs?
Release Note