test: add test for unavailableofferings checking instanceType on cp.List#1538
Merged
matthchr merged 1 commit intoAzure:mainfrom Mar 16, 2026
Merged
test: add test for unavailableofferings checking instanceType on cp.List#1538matthchr merged 1 commit intoAzure:mainfrom
matthchr merged 1 commit intoAzure:mainfrom
Conversation
MaximilianoUribe
approved these changes
Mar 16, 2026
Collaborator
MaximilianoUribe
left a comment
MaximilianoUribe
left a comment
There was a problem hiding this comment.
lgtm, was this a bug or an issue?
Member
Author
|
No but I thought there was one so I added this test, which showed it was actually fine. The case is interesting though (sku that has since been offering restricted) so figured it was worth keeping the test regardless for regression reasons. |
comtalyst
reviewed
Mar 17, 2026
comtalyst
added a commit
that referenced
this pull request
Mar 23, 2026
Remove tests and assertions that were invalidated by recently merged PRs but survived the rebase because the conflict resolution didn't catch them: - Remove 7 stale GC tests referencing creationtimestamp tag deleted by #1468 (MachineStatus migration). These tests called the non-existent instance.AKSMachineTimestampToTag function, causing compile failure. - Remove duplicate E2E tests from instancetype/suite_test.go (Zone-aware, CloudProvider Create Error Cases, Unavailable Offerings) that are already covered by shared tests in cloudprovider/suite_offerings_test.go. These duplicates referenced the removed nodePool variable. - Add missing Azure test/expectations dot-import to suite_test.go for ExpectProvisionedAndWaitForPromises (used by test added in #1538). - Remove stale creationtimestamp tag assertion from suite_features_test.go (tag removed by #1468). - Restore ScaleSetPrioritySpot assertion from #1546 (allocationstrategy provider) by adding priority field to creationResult struct, preserving the test's intention in the reunified framework. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
comtalyst
added a commit
that referenced
this pull request
Mar 28, 2026
Remove tests and assertions that were invalidated by recently merged PRs but survived the rebase because the conflict resolution didn't catch them: - Remove 7 stale GC tests referencing creationtimestamp tag deleted by #1468 (MachineStatus migration). These tests called the non-existent instance.AKSMachineTimestampToTag function, causing compile failure. - Remove duplicate E2E tests from instancetype/suite_test.go (Zone-aware, CloudProvider Create Error Cases, Unavailable Offerings) that are already covered by shared tests in cloudprovider/suite_offerings_test.go. These duplicates referenced the removed nodePool variable. - Add missing Azure test/expectations dot-import to suite_test.go for ExpectProvisionedAndWaitForPromises (used by test added in #1538). - Remove stale creationtimestamp tag assertion from suite_features_test.go (tag removed by #1468). - Restore ScaleSetPrioritySpot assertion from #1546 (allocationstrategy provider) by adding priority field to creationResult struct, preserving the test's intention in the reunified framework. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
comtalyst
added a commit
that referenced
this pull request
Mar 31, 2026
Remove tests and assertions that were invalidated by recently merged PRs but survived the rebase because the conflict resolution didn't catch them: - Remove 7 stale GC tests referencing creationtimestamp tag deleted by #1468 (MachineStatus migration). These tests called the non-existent instance.AKSMachineTimestampToTag function, causing compile failure. - Remove duplicate E2E tests from instancetype/suite_test.go (Zone-aware, CloudProvider Create Error Cases, Unavailable Offerings) that are already covered by shared tests in cloudprovider/suite_offerings_test.go. These duplicates referenced the removed nodePool variable. - Add missing Azure test/expectations dot-import to suite_test.go for ExpectProvisionedAndWaitForPromises (used by test added in #1538). - Remove stale creationtimestamp tag assertion from suite_features_test.go (tag removed by #1468). - Restore ScaleSetPrioritySpot assertion from #1546 (allocationstrategy provider) by adding priority field to creationResult struct, preserving the test's intention in the reunified framework. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How was this change tested?
Does this change impact docs?
Release Note