Skip to content

feat: add support for kubernetes.azure.com/priority label#1645

Merged
matthchr merged 3 commits intomainfrom
matthchr/priority-label
Apr 27, 2026
Merged

feat: add support for kubernetes.azure.com/priority label#1645
matthchr merged 3 commits intomainfrom
matthchr/priority-label

Conversation

@matthchr
Copy link
Copy Markdown
Member

@matthchr matthchr commented Apr 24, 2026

This should be preferred over the scalesetpriority variant

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


This should be preferred over the scalesetpriority variant
@matthchr matthchr force-pushed the matthchr/priority-label branch from e03f72c to 9a84e86 Compare April 24, 2026 19:33
Copy link
Copy Markdown
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Something to consider for later (nothing blocking):

  • Let's maybe update the 0006-requirements-and-labels.md with the new label? (And let's not forget the user-facing docs.)
  • Do we need guidance on that capacity-type, scalesetpriority, and priority should not be mixed (unless the values agree) - or is it obvious? And maybe a preference? (capacity-type as canonical in Karpenter, unless one of the others needed for compatibility?)
  • Wondering if we should look into surfacing “no instance types available” better (maybe with reason?) - as we introduce (more?) ways to have conflicting requirements ...

@matthchr
Copy link
Copy Markdown
Member Author

Wondering if we should look into surfacing “no instance types available” better (maybe with reason?) - as we introduce (more?) ways to have conflicting requirements ...

Yeah this would be good to do for sure. I've had issues in the past where we ask for conflicting requirements and it's not that easy to figure out. I am not sure that this is really going to increase that chance much. There are lots of other ways we already have that result in this situation, but filed an issue for this here: #1657

Do we need guidance on that capacity-type, scalesetpriority, and priority should not be mixed (unless the values agree) - or is it obvious? And maybe a preference? (capacity-type as canonical in Karpenter, unless one of the others needed for compatibility?)

I will add it in the public docs.

Let's maybe update the 0006-requirements-and-labels.md with the new label? (And let's not forget the user-facing docs.)

Sent a PR for this

@matthchr matthchr merged commit 4c2ab97 into main Apr 27, 2026
14 checks passed
@matthchr matthchr deleted the matthchr/priority-label branch April 27, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants