feat: add support for kubernetes.azure.com/priority label#1645
feat: add support for kubernetes.azure.com/priority label#1645
Conversation
This should be preferred over the scalesetpriority variant
e03f72c to
9a84e86
Compare
tallaxes
left a comment
There was a problem hiding this comment.
LGTM. Something to consider for later (nothing blocking):
- Let's maybe update the 0006-requirements-and-labels.md with the new label? (And let's not forget the user-facing docs.)
- Do we need guidance on that
capacity-type,scalesetpriority, andpriorityshould not be mixed (unless the values agree) - or is it obvious? And maybe a preference? (capacity-typeas canonical in Karpenter, unless one of the others needed for compatibility?) - Wondering if we should look into surfacing “no instance types available” better (maybe with reason?) - as we introduce (more?) ways to have conflicting requirements ...
Yeah this would be good to do for sure. I've had issues in the past where we ask for conflicting requirements and it's not that easy to figure out. I am not sure that this is really going to increase that chance much. There are lots of other ways we already have that result in this situation, but filed an issue for this here: #1657
I will add it in the public docs.
Sent a PR for this |
This should be preferred over the scalesetpriority variant
Description
How was this change tested?
Does this change impact docs?
Release Note