Conversation
tadelesh
requested review from
allenjzhang,
bterlson,
markcowl and
timotheeguerin
as code owners
Collaborator
|
All changed packages have been documented.
|
Collaborator
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/745/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/745/ |
iscai-msft
approved these changes
Apr 29, 2024
Contributor
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
looks good to me, @timotheeguerin are you ok with this change? Are there any other places we should add this code?
Background is: we decided for tcgc we are going to by default project to the last version, you can override this with flag api-version
tadelesh
requested review from
joheredi,
lmazuel,
m-nash and
srnagar
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since autorest emitter needs to generate multiple version swagger, need to pass
allto tcgc to prevent tcgc do the versioning projection tolatestversion.