Skip to content

Support morph target weights in glTF animation pointer and interactivity #16778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Jun 20, 2025

No description provided.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

@bghgary bghgary force-pushed the gltf-animation-pointer-morph-targets branch from a7b2df1 to 4a5d193 Compare June 20, 2025 19:56
@bghgary bghgary changed the title Support targeting morph target weights in glTF animation pointer and interactivity Support morph target weights in glTF animation pointer and interactivity Jun 20, 2025
@bghgary bghgary added the bug label Jun 20, 2025
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16778/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16778/merge/?snapshot=refs/pull/16778/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16778/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16778/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16778/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16778/merge/?snapshot=refs/pull/16778/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2025

Comment on lines -102 to -104
if (!obj.info.interpolation) {
throw new Error(`${extensionContext}/pointer: Interpolation is missing`);
}
Copy link
Contributor Author

@bghgary bghgary Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was inside the try/catch, so it didn't actually propagate out as the correct error.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 21, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16778/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 21, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16778/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16778/merge/?snapshot=refs/pull/16778/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 21, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants