Add litellm call id passing to Aim guardrails on pre and post-hooks calls #10021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -152,16 +152,16 @@ async def common_processing_pre_call_logic( | |||
| ): | |||
| self.data["model"] = litellm.model_alias_map[self.data["model"]] | |||
|
|
|||
| self.data["litellm_call_id"] = request.headers.get( | |||
There was a problem hiding this comment.
if order is important, this should be a tested flow - otherwise there can be regressions
There was a problem hiding this comment.
You're totally right! Created a new test file test/litellm/proxy/test_common_request_processing.py with the test that checks this specific behavior.
|
Hey @hxmichael if a test file doesn't exist, please create one with the relevant imports - https://github.com/BerriAI/litellm/tree/main/tests/litellm/proxy |
…n common_request_processing called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Add litellm call id passing to Aim guardrails on pre and post-hooks calls
Pre-Submission checklist
tests/litellm/directory, Adding at least 1 test is a hard requirement - see details(Unfortunately, we didn't find where the
litellm/proxy/common_request_processing.pytests are, would appreciate some pointers)make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]Type
🆕 New Feature
Thank you in advance for the review!