Skip to content

Support max_completion_tokens on Sagemaker #10243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

simha104
Copy link
Contributor

@simha104 simha104 commented Apr 23, 2025

Support max_completion_tokens on Sagemaker

Relevant issues

Fixes #10243

Pre-Submission checklist

image
image

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on (make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix
🧹 Refactoring
✅ Test

Changes

Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:14pm

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ishaan-jaff ishaan-jaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simha104 LGTM, can you sign the CLA

@simha104 simha104 requested a review from ishaan-jaff April 24, 2025 16:21
@ishaan-jaff ishaan-jaff changed the base branch from main to litellm_sagemaker_max_tokens_fixes April 25, 2025 01:58
@ishaan-jaff ishaan-jaff merged commit 3fdb82d into BerriAI:litellm_sagemaker_max_tokens_fixes Apr 25, 2025
6 checks passed
ishaan-jaff added a commit that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants