Skip to content

Keys and tools pages: Use proper terminology for loading and no data cases #10253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

msabramo
Copy link
Contributor

Title

Keys page: Use keys rather than logs terminology

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on (make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix
🧹 Refactoring

Changes

Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 0:15am

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2025

CLA assistant check
All committers have signed the CLA.

@msabramo msabramo force-pushed the logs-to-keys-messages-in-keys-page branch from 58c1ff0 to 5e427ed Compare April 24, 2025 00:14
@msabramo msabramo changed the title Keys page: Use keys rather than logs terminology Keys and tools pages: Use proper terminology for loading and no data cases Apr 24, 2025
@krrishdholakia
Copy link
Contributor

Does this pass linting?

cd ui/litellm_dashboard && ./build_ui.sh

@msabramo
Copy link
Contributor Author

msabramo commented Apr 24, 2025

Does this pass linting?

cd ui/litellm_dashboard && ./build_ui.sh

Yes.

abramowi at marcs-mbp-3 in ~/Code/OpenSource/litellm (logs-to-keys-messages-in-keys-page●)
$ cd ui/litellm-dashboard && ./build_ui.sh
...
Build successful. Copying files...

/Users/abramowi/Code/OpenSource/litellm/ui/litellm-dashboard
Deployment completed.

@krrishdholakia krrishdholakia merged commit 56d00c4 into BerriAI:main Apr 24, 2025
6 checks passed
@msabramo msabramo deleted the logs-to-keys-messages-in-keys-page branch April 25, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants