Skip to content

make openai model O series conditional accept provider/model #10591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

aholmberg
Copy link
Contributor

Registration and calls within the project are not consistent. This accepts either form.

ref: #10566

Title

make openai model O series conditional accept provider/model

Relevant issues

Fixes #10566

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
    image

  • I have added a screenshot of my new test passing locally

  • My PR passes all unit tests on make test-unit

  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix
✅ Test

Changes

make openai model O series conditional accept provider/model

Registration and calls within the project are not consistent.
This accepts either form.

ref: BerriAI#10566
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 0:03am

@CLAassistant
Copy link

CLAassistant commented May 6, 2025

CLA assistant check
All committers have signed the CLA.

@krrishdholakia krrishdholakia merged commit 33953bd into BerriAI:main May 7, 2025
6 checks passed
@krrishdholakia
Copy link
Contributor

Thanks @aholmberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: o3 is missing reasoning_effort in supported_openai_params
3 participants