Support OTLP standard environment variables for configuration #10813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Environment variables outlined at https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/ - Default to OTLP standard, but fallback to existing so as to not break backwards compatibility
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
Apologies for not running tests locally, had all sorts of errors on "Installing tiktoken" that I'd have to dive into much deeper than an environment variable change to understand |
damienpontifex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support open telemetry standard environment variables for OTLP exporter
Systems often inject these variables, or equally developers expect to have a consistent set of configuration options when relating to opentelemetry. Environment variables for the open telemetry OTLP exporter are outlined at https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/ for their standards.
This adds in the option to utilise those environment variables, without introducing a breaking change, by falling back to the currently documented process.
Relevant issues
Relates to #9901
Also relates to PR #9972 but I had confusion on that PR, as it doesn't reference environment variables such as
OTEL_EXPORTER_OTLP_PROTOCOL, orOTEL_EXPORTER_OTLP_ENDPOINTas I had expectedPre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
📖 Documentation
Changes
OTEL_EXPORTER_OTLP_PROTOCOLofgrpc,http/protobuf, orhttp/jsonas outlined at https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#otel_exporter_otlp_protocol