feat: Make gemini accept the openai parameter parallel_tool_calls #11125
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@krrishdholakia I think this CI failure is unrelated to the change. Can you corroborate? |
|
Hey @aholmberg if you rebase with main, it should be fixed |
tests/llm_translation/test_vertex.py
Outdated
There was a problem hiding this comment.
move this test inside tests/litellm so it can run on the github action (llm_translation tests are mixed with real api calls, so don't run on contributor pr's)
| if value is False: | ||
| tools = non_default_params.get("tools", non_default_params.get("functions")) | ||
| num_function_declarations = len(tools) if isinstance(tools, list) else 0 | ||
| if num_function_declarations > 1: |
There was a problem hiding this comment.
add support for user setting either completion(...,drop_params = True) or litellm.drop_params = True
if so - i assume we would just not set this flag parallel_tool_calls=False
There was a problem hiding this comment.
I'm not sure what is meant by this comment. The way I was thinking about it, parallel tool calls True is the default. If it's set True we don't need to inject anything. This new logic is just bailing if it's being set False and more than one tool is present (no way I know of to emulate that in Gemini).
When mapping, allow the parameter: True because that is the intrinsic behavior of Gemini. Allow False, but reject if there are multiple tools because there's no actual equivalent in Gemini. fixes BerriAI#9686 ref: issues/9686
|
Rebased and moved the test. |
When mapping, allow the parameter: True because that is the intrinsic behavior of Gemini. Allow False, but reject if there are multiple tools because there's no actual equivalent in Gemini.
fixes #9686
ref: issues/9686
Title
Relevant issues
fixes #9686
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
I have Added testing in the
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsI have added a screenshot of my new test passing locally
My PR passes all unit tests on
make test-unitMy PR's scope is as isolated as possible, it only solves 1 specific problem
Type
🆕 New Feature
🐛 Bug Fix
Changes
When mapping, allow the parameter: True because that is the intrinsic behavior of Gemini. Allow False, but reject if there are multiple tools because there's no actual equivalent in Gemini.