[Fix] Rollback to httpx==0.27.0 #11146
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the dependency on httpx‐aiohttp to support an older version of httpx by adjusting transport creation logic and cleaning up related tests and code. Key changes include:
- Removal of the aiohttp transport creation test from tests/litellm/llms/custom_httpx/test_http_handler.py.
- Deletion of the httpx-aiohttp dependency in pyproject.toml.
- Simplification of the transport creation condition in http_handler.py by eliminating the aiohttp_transport_exists check.
- Updates in aiohttp_transport.py to support the revised transport handling.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/litellm/llms/custom_httpx/test_http_handler.py | Removed test for aiohttp transport creation |
| pyproject.toml | Removed the httpx-aiohttp dependency |
| litellm/llms/custom_httpx/http_handler.py | Simplified transport creation logic |
| litellm/llms/custom_httpx/aiohttp_transport.py | Updates to exception mapping and transport class implementation |
Comments suppressed due to low confidence (1)
pyproject.toml:23
- Consider updating the project's dependency documentation or migration notes to reflect the removal of the 'httpx-aiohttp' dependency.
httpx = ">=0.23.0"
| AsyncHTTPHandler._should_use_aiohttp_transport() | ||
| and AsyncHTTPHandler.aiohttp_transport_exists() | ||
| ): | ||
| if AsyncHTTPHandler._should_use_aiohttp_transport(): |
There was a problem hiding this comment.
Update the associated docstring or inline comments to indicate that the 'aiohttp_transport_exists' check has been removed, ensuring that future maintainers understand the adjusted transport creation logic.
Copilot uses AI. Check for mistakes.
ishaan-jaff
changed the title
* fix - fix - use old httpx version * fix - fix - use old httpx version * fix: test * fix: comment
|
Hello, any reason why the pin to httpx is set back to 0.27.0? 0.28.1 has nice improvements to SSL certificates handling that would help very much in a corporate environment. |
[Fix] Rollback to httpx==0.27.0
This PR removes the dependency on httpx‐aiohttp to support an older version of httpx by adjusting transport creation logic
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
✅ Test
Changes