[Fix] Fix SCIM running patch operation case sensitivity #11335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a case sensitivity bug in handling SCIM PATCH operations by normalizing the operation values. Key changes include:
- Adding tests in tests/test_litellm/proxy/management_endpoints/scim/test_scim_transformations.py to validate lowercase, uppercase, and mixed-case inputs.
- Updating SCIMPatchOperation in litellm/types/proxy/management_endpoints/scim_v2.py with a field validator to ensure the op value is normalized and restricted correctly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_litellm/proxy/management_endpoints/scim/test_scim_transformations.py | Added tests covering various casings for SCIM PATCH operations |
| litellm/types/proxy/management_endpoints/scim_v2.py | Introduced a field validator to normalize op values and enforce allowed values |
Comments suppressed due to low confidence (2)
litellm/types/proxy/management_endpoints/scim_v2.py:83
- Consider adding tests to verify that invalid op values raise a ValueError, ensuring that the field validator covers erroneous inputs.
v_lower = v.lower()
tests/test_litellm/proxy/management_endpoints/scim/test_scim_transformations.py:285
- Add negative test cases for SCIMPatchOperation with invalid op values to ensure robust error handling in the validator.
assert op_minimal.value is None
stefan--
pushed a commit
to stefan--/litellm
that referenced
this pull request
Jun 12, 2025
* fix: fix SCIM patch op * test: test SCIM patch op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix] Fix SCIM running patch operation case sensitivity
This PR fixes a case sensitivity bug in handling SCIM PATCH operations by normalizing the operation values. Key changes include:
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
✅ Test
Changes