-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Feat/add delete callback #11654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add delete callback #11654
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @jtong99 thank you for the PR - can you please fix the linting errors and move your test to be a mock test inside |
Hi @krrishdholakia , I fixed the linting errors and moved the test case. Please help me check the PR and tell me if anything need change. Thanks. |
Hi @krrishdholakia , I found that when user add a callback, the UI did not automatically close the popup and refetch the data. I would like to contribute to enhance the UX, should I add it under this PR? |
Hi @jtong99 , can you also update the document related to your fix? Since there is very little maintenance work for the document it might be a good idea to update it so users can follow the guide properly. |
Hi @krrishdholakia , when you have some time may you take a look at this PR? I think @jtong99 has made all the updates you requested. Thank you very much! |
Thanks for the bump @vuanhtu52 thanks for the work on this @jtong99 |
this would be helpful! if you can file a separate PR for this, that'd be great! |
Title
Implement delete Active Logging Callbacks feature
Relevant issues
Fixes #9348
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/
directory, Adding at least 1 test is a hard requirement - see detailsmake test-unit
Type
🆕 New Feature
Changes
In
proxy_server.py
:delete_callback
endpoint at/config/callback/delete
In
networking.tsx
:deleteCallback
function to make API calls to the delete endpointIn
settings.tsx
:handleDeleteCallback
function to trigger deletion workflowconfirmDeleteCallback
function for confirmation dialog