Fixing watsonx error: 'model_id' or 'model' cannot be specified in the request body for models in a deployment space #11854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e request body for models in a deployment space
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| # watsonx: Deployment models do not support 'model_id' in their payload | ||
| # https://github.com/BerriAI/litellm/issues/11837 | ||
| "model": None | ||
| if custom_llm_provider == "watsonx" and model.startswith("deployment/") |
There was a problem hiding this comment.
this is the wrong place for this change. it should be inside watsonx/chat/transformation or watsonx/completion/transformation.
| @@ -218,3 +219,4 @@ def test_watsonx_deployment_space_id_embedding(monkeypatch, watsonx_embedding_ca | |||
| assert mock_post.call_count == 1 | |||
| json_data = json.loads(mock_post.call_args.kwargs["data"]) | |||
| assert my_fake_space_id not in json_data | |||
| assert json_data.get("model") is None | |||
There was a problem hiding this comment.
please add a unit test for your change inside test_litellm/
…ed in the request body for models in a deployment space" This reverts commit 9d16a30.
|
Thanks for the feedback @krrishdholakia. I've implemented the requested changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fixing watsonx error: 'model_id' or 'model' cannot be specified in the request body for models in a deployment space.
Relevant issues
Fixes #11837
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
This PR sets the field "model" in the JSON payload to
Nonefor watsonx provider when the model is part of a custom deployment to fix the issue #11837. As explain in the issue, this issue happens for the providerwatsonxand not forwatsonx_text.Screenshot with integration tests passing for watsonx
Screenshot with unit tests passing
Error before the changes
Result after the changes