Skip to content

Fix clickable model ID in health check table #11898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

colesmcintosh
Copy link
Collaborator

@colesmcintosh colesmcintosh commented Jun 19, 2025

Title

Fix clickable model ID in health check table

Relevant issues

Fixes P0 issue where blue Model ID buttons appeared clickable but did nothing when clicked.

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix

Changes

This PR fixes the health check UI table by making the Model ID buttons functional and improving the selection logic:

What was broken:

  • Blue Model ID buttons looked clickable but did nothing when clicked
  • Header "select all" checkbox wasn't properly selecting all models
  • Checkbox clicks were triggering table sorting

What's fixed:

  1. Made Model ID buttons clickable: Added setSelectedModelId prop and onClick handler to open model details view
  2. Fixed checkbox selection logic:
    • Header checkbox now properly selects/deselects all models
    • Individual model checkboxes work correctly
    • Selection logic consistently uses model names
  3. Added stopPropagation: Prevents checkbox clicks from triggering unwanted table sorting
  4. Maintained separation of concerns:
    • Model ID clicks → open model details (uses model ID)
    • Checkbox selection → health check selection (uses model name)

Files Changed:

  • ui/litellm-dashboard/src/components/model_dashboard/health_check_columns.tsx: Added clickable functionality and fixed selection logic
  • ui/litellm-dashboard/src/components/model_dashboard/HealthCheckComponent.tsx: Added setSelectedModelId prop support
  • ui/litellm-dashboard/src/components/model_dashboard.tsx: Passed setSelectedModelId prop down

Impact

This improves the user experience by:

  • Making UI elements behave as expected (clickable buttons actually work)
  • Fixing bulk selection functionality for health checks
  • Reducing user confusion and frustration

… prop to make blue model ID buttons clickable - Fix checkbox selection logic to use model names consistently - Add stopPropagation to prevent unwanted sort triggers on checkbox clicks - Now clicking Model ID opens model details, and select all works properly
Copy link

vercel bot commented Jun 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 9:04pm

@colesmcintosh colesmcintosh marked this pull request as ready for review June 19, 2025 21:06
Copy link
Contributor

@ishaan-jaff ishaan-jaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I get a screenshot or Loom of this

@colesmcintosh
Copy link
Collaborator Author

Can I get a screenshot or Loom of this

Loom Demo

Copy link
Contributor

@ishaan-jaff ishaan-jaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishaan-jaff ishaan-jaff merged commit d2e5494 into BerriAI:main Jun 19, 2025
6 checks passed
@colesmcintosh colesmcintosh deleted the fix-clickable-model-id branch June 24, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants