fix(proxy): Fix test_mock_create_audio_file by adding managed_files hook #12072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing because the managed_files hook was not configured. This fix adds a DummyManagedFiles class and mocks the create_file function as an AsyncMock to ensure proper test execution.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@colesmcintosh please merge once the mock tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix test_mock_create_audio_file by adding managed_files hook
Relevant issues
Fixes failing test in CI
Pre-Submission checklist
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
The
test_mock_create_audio_filetest was failing with:The root cause was that the
managed_fileshook was not configured in the test setup, causing the files endpoint to return a 500 error ("Managed files hook not found") before reaching the mockedcreate_filefunction.This PR fixes the test by:
DummyManagedFilesclass that implementsBaseFileEndpointsproxy_logging_obj.proxy_hook_mappingto bypass the enterprise feature checklitellm.files.main.create_fileas an AsyncMockcreate_file_requestTest Results