[Bug Fix] Invite links email should contain the correct invite id #12130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the bug where invite links in emails were using an incorrect invite ID. It also enhances test coverage for invitation link generation and refactors invitation creation logic across proxy components.
- Added tests to validate both new and existing invitation handling.
- Refactored invitation creation in proxy server and email modules.
- Updated cost configurations to support additional fields.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_litellm/enterprise/enterprise_callbacks/send_emails/test_base_email.py | Added tests to verify correct invitation link generation under various scenarios. |
| litellm/proxy/proxy_server.py | Modified invitation creation to leverage a helper and wrapped exceptions with a handler. |
| litellm/proxy/management_helpers/user_invitation.py | Added new helper function for creating invitations with proper error handling. |
| litellm/model_prices_and_context_window_backup.json | Expanded cost configuration fields for new features. |
| enterprise/litellm_enterprise/enterprise_callbacks/send_emails/base_email.py | Refactored invitation link generation with early validations, client availability checks, and improved asynchronous handling. |
enterprise/litellm_enterprise/enterprise_callbacks/send_emails/base_email.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bug Fix] Invite links email should contain the correct invite id
Fixes #11978
Ensure the correct email / invite link is sent when using tf providers or API for inviting users to LiteLLM.
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
✅ Test
Changes